[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 18/35] target/arm: Implement SVE Floating Poi

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 18/35] target/arm: Implement SVE Floating Point Multiply Indexed Group
Date: Tue, 26 Jun 2018 07:50:33 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/25/2018 10:47 AM, Peter Maydell wrote:
>> +                           status, vsz, vsz, a->index * 2 + a->sub,
> Why are we multiplying the index by 2 here? Are we just encoding
> (index, sub) into a constant to pull out again the other side?
> If so, comment might help. (Also I find shifts and ors make it
> clearer that we're just shifting values around; multiplication
> and addition to me implies that we're really doing arithmetic.)

Yes, this is just encoding.
I sometimes use multiply and add to avoid needing extra parenthesis.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]