[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] pr-manager-helper: avoid SIGSEGV when writi
From: |
Michal Privoznik |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] pr-manager-helper: avoid SIGSEGV when writing to the socket fail |
Date: |
Tue, 26 Jun 2018 18:24:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/26/2018 05:40 PM, Paolo Bonzini wrote:
> When writing to the qemu-pr-helper socket failed, the persistent
> reservation manager was correctly disconnecting the socket, but it
> did not clear pr_mgr->ioc. So the rest of the code did not know
> that the socket had been disconnected, accessed pr_mgr->ioc and
> happily caused a crash.
>
> To reproduce, it is enough to stop qemu-pr-helper between QEMU
> startup and executing e.g. sg_persist -k /dev/sdb.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> scsi/pr-manager-helper.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Michal Privoznik <address@hidden>
Michal
[Qemu-devel] [PATCH 2/5] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN, Paolo Bonzini, 2018/06/26