[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that ha
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO |
Date: |
Wed, 27 Jun 2018 15:15:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 27/06/2018 13:13, Gerd Hoffmann wrote:
> Hi,
>
>> Given the code runs under big qemu lock anyway the atomics are not
>> needed, so we could drop just them. I left them in nevertheless because
>>
>> (a) we might want try run the code in a thread instead of using a timer,
>> and
>> (b) I was too lazy to rewrite the code to drop the atomics.
>>
>> I'd prefer to keep option (a) ...
>
> Well, experimented with that a bit.
>
> As long as the core audio system runs using qemu timers too moving to a
> thread doesn't buy us much as any latency spikes in qemu will hit us no
> matter what.
>
> So, that point is moot. I'll go drop the atomics.
Try stat64. It should work just fine as it's made exactly for this kind
of simple counter.
Paolo
- Re: [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO), (continued)
- Re: [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO), Daniel P . Berrangé, 2018/06/27
- Re: [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO), Alex Bennée, 2018/06/27
- Re: [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO), Philippe Mathieu-Daudé, 2018/06/27
- Re: [Qemu-devel] Drop support for 32bit hosts in qemu?, Juan Quintela, 2018/06/27
- Re: [Qemu-devel] Drop support for 32bit hosts in qemu?, Daniel P . Berrangé, 2018/06/27
- Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO, Gerd Hoffmann, 2018/06/27
- Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO, Eric Blake, 2018/06/27
Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO, Peter Maydell, 2018/06/29
[Qemu-devel] [PULL 4/6] audio/hda: detect output buffer overruns, Gerd Hoffmann, 2018/06/25
[Qemu-devel] [PULL 5/6] audio/hda: enable new timer code by default., Gerd Hoffmann, 2018/06/25
[Qemu-devel] [PULL 6/6] audio: Convert use of atoi to qemu_strtoi, Gerd Hoffmann, 2018/06/25
Re: [Qemu-devel] [PULL 0/6] Audio 20180625 patches, Peter Maydell, 2018/06/25