Re: [Qemu-devel] [RFC v3 06/10] ESP: add pseudo-DMA as used by Macintosh

[Laurent Vivier]

Le 28/06/2018 à 10:13, Paolo Bonzini a écrit :
> On 28/06/2018 01:29, Laurent Vivier wrote:
>>      int32_t ti_size;
>> @@ -46,6 +47,11 @@ struct ESPState {
>>      ESPDMAMemoryReadWriteFunc dma_memory_write;
>>      void *dma_opaque;
>>      void (*dma_cb)(ESPState *s);
>> +    uint8_t pdma_buf[32];
>> +    uint32_t pdma_len;
>> +    uint8_t *pdma_start;
>> +    uint8_t *pdma_cur;
>> +    void (*pdma_cb)(ESPState *s);
>>  };
> 
> I suppose migration of ESP is completely busted, since we're not
> migrating dma_cb?  This patch is not making it any better, but perhaps
> at least pdma_start and pdma_cur could be indices instead of pointers.

Thank you, I will try that.

Laurent