[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup |
Date: |
Thu, 28 Jun 2018 17:51:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 28/06/2018 16:46, Eric Blake wrote:
> On 06/28/2018 08:28 AM, Paolo Bonzini wrote:
>> On 28/06/2018 15:22, Eric Blake wrote:
>>>>>
>>>>> -qemu-system-i386 [...OPTIONS...] -vnc :1,tls,x509=/etc/pki/qemu
>>>>> -monitor stdio
>>>>> +qemu-system-i386 [...OPTIONS...] \
>>>>> + -object
>>>>> tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=no
>>>>>
>>>>> \
>>>
>>> I'd use --object here (especially since -object cannot be used on
>>> qemu-nbd, but --object tls-creds-x509 can).
>>
>> But that would be inconsistent with -vnc.
>>
>> I honestly don't understand the crusade against single-dashed options.
>
> Rather, it's a crusade FOR the use of --object, for consistency reasons:
>
> These work:
>
> qemu-system-i386 -object foo
> qemu-system-i386 --object foo
> qemu-nbd --object foo
>
> but this fails:
>
> qemu-nbd -object foo
>
> And since --object blurbs can a) be quite long, and b) be quite useful
> for pasting between apps, then it stands to reason that our
> documentation should prefer the form that is easiest to reuse everywhere.
It's also inconsistent with the rest of the command line, though, and it
may wrongly give the impression that single-character options can be
combined.
Paolo