[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 47/55] target/arm: Remove redundant DIV detection for
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 47/55] target/arm: Remove redundant DIV detection for KVM |
Date: |
Fri, 29 Jun 2018 15:53:39 +0100 |
From: Aaron Lindsay <address@hidden>
KVM implies V7VE, which implies ARM_DIV and THUMB_DIV. The conditional
detection here is therefore unnecessary. Because V7VE is already
unconditionally specified for all KVM hosts, ARM_DIV and THUMB_DIV are
already indirectly specified and do not need to be included here at all.
Signed-off-by: Aaron Lindsay <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
---
target/arm/kvm32.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/target/arm/kvm32.c b/target/arm/kvm32.c
index fb9ea37a318..4e91c11796b 100644
--- a/target/arm/kvm32.c
+++ b/target/arm/kvm32.c
@@ -36,7 +36,7 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
* and then query that CPU for the relevant ID registers.
*/
int i, ret, fdarray[3];
- uint32_t midr, id_pfr0, id_isar0, mvfr1;
+ uint32_t midr, id_pfr0, mvfr1;
uint64_t features = 0;
/* Old kernels may not know about the PREFERRED_TARGET ioctl: however
* we know these will only support creating one kind of guest CPU,
@@ -58,11 +58,6 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
| ENCODE_CP_REG(15, 0, 0, 0, 1, 0, 0),
.addr = (uintptr_t)&id_pfr0,
},
- {
- .id = KVM_REG_ARM | KVM_REG_SIZE_U32
- | ENCODE_CP_REG(15, 0, 0, 0, 2, 0, 0),
- .addr = (uintptr_t)&id_isar0,
- },
{
.id = KVM_REG_ARM | KVM_REG_SIZE_U32
| KVM_REG_ARM_VFP | KVM_REG_ARM_VFP_MVFR1,
@@ -106,18 +101,6 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures
*ahcf)
set_feature(&features, ARM_FEATURE_VFP3);
set_feature(&features, ARM_FEATURE_GENERIC_TIMER);
- switch (extract32(id_isar0, 24, 4)) {
- case 1:
- set_feature(&features, ARM_FEATURE_THUMB_DIV);
- break;
- case 2:
- set_feature(&features, ARM_FEATURE_ARM_DIV);
- set_feature(&features, ARM_FEATURE_THUMB_DIV);
- break;
- default:
- break;
- }
-
if (extract32(id_pfr0, 12, 4) == 1) {
set_feature(&features, ARM_FEATURE_THUMB2EE);
}
--
2.17.1
- [Qemu-devel] [PULL 38/55] target/arm: Implement SVE dot product (vectors), (continued)
- [Qemu-devel] [PULL 38/55] target/arm: Implement SVE dot product (vectors), Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 43/55] i.mx7d: Remove unused header files, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 44/55] i.mx7d: Change SRC unimplemented device name from sdma to src, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 34/55] target/arm: Implement SVE floating-point complex add, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 41/55] target/arm: Implement ARMv8.2-DotProd, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 48/55] target/arm: Mark PMINTENSET accesses as possibly doing IO, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 49/55] sd: Don't trace SDRequest crc field, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 45/55] i.mx7d: Change IRQ number type from hwaddr to int, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 51/55] target/arm: Fix SVE signed division vs x86 overflow exception, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 52/55] target/arm: Fix SVE system register access checks, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 47/55] target/arm: Remove redundant DIV detection for KVM,
Peter Maydell <=
- [Qemu-devel] [PULL 31/55] target/arm: Implement SVE floating-point round to integral value, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 40/55] target/arm: Enable SVE for aarch64-linux-user, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 42/55] target/arm: support reading of CNT[VCT|FRQ]_EL0 from user-space, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 46/55] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 53/55] target/arm: Prune a57 features from max, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 54/55] target/arm: Prune a15 features from max, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 55/55] target/arm: Add ID_ISAR6, Peter Maydell, 2018/06/29
- [Qemu-devel] [PULL 50/55] sdcard: Use the ldst API, Peter Maydell, 2018/06/29
- Re: [Qemu-devel] [PULL 00/55] target-arm queue, Peter Maydell, 2018/06/30