Re: [Qemu-devel] [PATCH 6/6] target/arm: Set ISAR bits for -cpu max

[Richard Henderson]

On 06/29/2018 01:42 AM, Peter Maydell wrote:
> On 29 June 2018 at 01:15, Richard Henderson
> <address@hidden> wrote:
>> For the supported extensions, fill in the appropriate bits in
>> ID_ISAR5, ID_ISAR6, ID_AA64ISAR0, ID_AA64ISAR1.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
> 
> This makes sense, but I'd rather have a bit of time to think
> about how exactly we want to handle feature bits vs ID
> register values (the current codebase is not entirely
> coherent on the topic), so I'd rather not put this in
> for softfreeze unless there's a strong reason we should...

Fair.

I was wondering if we'd post-process the feature bits to initialize the id
registers, so that we don't have different places with the same knowledge.

The clearing of EL3 bits from id_pfr1 is an example of that already.


r~