qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefi


From: Joe Perches
Subject: Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions
Date: Fri, 29 Jun 2018 14:46:09 -0700

On Fri, 2018-06-29 at 15:41 -0500, Eric Blake wrote:
> On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote:
> > Do not match the IEC binary prefix as camelcase typedefs.
> > 
> > This fixes:
> > 
> >      ERROR: "foo * bar" should be "foo *bar"
> >      #310: FILE: hw/ppc/ppc440_uc.c:564:
> >      +        size = 8 * MiB * sh;
> >      total: 1 errors, 0 warnings, 433 lines checked

Does the linux kernel use these?
I don't believe so.

> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > @@ -242,6 +242,7 @@ our $UTF8       = qr{
> >   # There are still some false positives, but this catches most
> >   # common cases.
> >   our $typeTypedefs = qr{(?x:
> > +        (?![KMGTPE]iB)                      # IEC binary prefix (do not 
> > match)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]