[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefi
From: |
Joe Perches |
Subject: |
Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions |
Date: |
Fri, 29 Jun 2018 14:46:09 -0700 |
On Fri, 2018-06-29 at 15:41 -0500, Eric Blake wrote:
> On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote:
> > Do not match the IEC binary prefix as camelcase typedefs.
> >
> > This fixes:
> >
> > ERROR: "foo * bar" should be "foo *bar"
> > #310: FILE: hw/ppc/ppc440_uc.c:564:
> > + size = 8 * MiB * sh;
> > total: 1 errors, 0 warnings, 433 lines checked
Does the linux kernel use these?
I don't believe so.
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > @@ -242,6 +242,7 @@ our $UTF8 = qr{
> > # There are still some false positives, but this catches most
> > # common cases.
> > our $typeTypedefs = qr{(?x:
> > + (?![KMGTPE]iB) # IEC binary prefix (do not
> > match)
- Re: [Qemu-devel] [PATCH v5 01/46] include: Add IEC binary prefixes in "qemu/units.h", (continued)
[Qemu-devel] [PATCH v5 02/46] vdi: Use definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 03/46] x86/cpu: Use definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 05/46] hw: Use IEC binary prefix definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 06/46] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 07/46] hw/ivshmem: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 09/46] hw/scsi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 08/46] hw/ipack: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25
[Qemu-devel] [PATCH v5 10/46] hw/smbios: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/25