[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 03/20] build-system: remove per-test GCOV reporti
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v3 03/20] build-system: remove per-test GCOV reporting |
Date: |
Mon, 2 Jul 2018 15:30:04 +0100 |
I'm not entirely sure who's using this information and certainly in a
CI environment it just washes over as additional noise. Later patches
will provide new reporting options so a user who wants to analyse
individual tests will be able to use that to get the information.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
---
docs/devel/testing.rst | 11 +++++------
tests/Makefile.include | 10 ----------
2 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index f33e5a8423..66ef219f69 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for more
information.
GCC gcov support
----------------
-``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the
-tested code. To use it, configure QEMU with ``--enable-gcov`` option and build.
-Then run ``make check`` as usual. There will be additional ``gcov`` output as
-the testing goes on, showing the test coverage percentage numbers per analyzed
-source file. More detailed reports can be obtained by running ``gcov`` command
-on the output files under ``$build_dir/tests/``, please read the ``gcov``
+``gcov`` is a GCC tool to analyze the testing coverage by
+instrumenting the tested code. To use it, configure QEMU with
+``--enable-gcov`` option and build. Then run ``make check`` as usual.
+Reports can be obtained by running ``gcov`` command on the output
+files under ``$build_dir/tests/``, please read the ``gcov``
documentation for more information.
QEMU iotests
diff --git a/tests/Makefile.include b/tests/Makefile.include
index e8bb2d8f66..756474814a 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -891,26 +891,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,)
.PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS))
$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%:
subdir-%-softmmu $(check-qtest-y)
- $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,)
$(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
QTEST_QEMU_IMG=qemu-img$(EXESUF) \
MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 +
1))} \
gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y)
$(check-qtest-generic-y),"GTESTER","$@")
- $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y)
$(gcov-files-generic-y); do \
- echo Gcov report for $$f:;\
- $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \
- done,)
.PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y))
$(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: %
- $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,)
$(call quiet-command, \
MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 +
1))} \
gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER","$*")
- $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y)
$(gcov-files-generic-y); do \
- echo Gcov report for $$f:;\
- $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \
- done,)
# gtester tests with XML output
--
2.17.1
- [Qemu-devel] [PATCH v3 00/20] Travis, Code Coverage and Cross Build updates, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 02/20] travis: test out-of-tree builds, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 04/20] .gitignore: add .gcov files, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 03/20] build-system: remove per-test GCOV reporting,
Alex Bennée <=
- [Qemu-devel] [PATCH v3 05/20] docker: add gcovr to travis image, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 06/20] travis: add gcovr summary for GCOV build, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 01/20] travis: do not waste time cloning unused submodules, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 07/20] build-system: add clean-coverage target, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 13/20] docker: ubuntu: Use SDL2, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 10/20] linux-user: add gcov support to preexit_cleanup, Alex Bennée, 2018/07/02
- [Qemu-devel] [PATCH v3 09/20] linux-user: introduce preexit_cleanup, Alex Bennée, 2018/07/02