[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/32] qmp qemu-ga: Revert change that accidenta

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 09/32] qmp qemu-ga: Revert change that accidentally made qemu-ga accept "id"
Date: Mon, 2 Jul 2018 16:44:03 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/02/2018 11:21 AM, Markus Armbruster wrote:
Commit cf869d53172 "qmp: support out-of-band (oob) execution" changed
how we check "id":

     Note that in the patch I exported qmp_dispatch_check_obj() to be
     used to check the request earlier, and at the same time allowed
     "id" field to be there since actually we always allow that.

The part after "and" is ill-advised: it makes qemu-ga accept and
ignore "id".  Revert.

Signed-off-by: Markus Armbruster <address@hidden>
  monitor.c           | 14 ++++++++------
  qapi/qmp-dispatch.c |  2 --
  tests/test-qga.c    | 10 +++++-----
  3 files changed, 13 insertions(+), 13 deletions(-)

It might be nicer to teach qga to reply with id. But for the purposes of fixing regressions, this is reasonable.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]