Re: [Qemu-devel] [PATCH 18/32] qmp: Don't let JSON errors jump the queue

[Eric Blake]

On 07/02/2018 11:22 AM, Markus Armbruster wrote:
> handle_qmp_command() reports JSON syntax errors right away.  This is
> wrong when OOB is enabled, because the errors can "jump the queue"
> then.
>
> The previous commit fixed the same bug for semantic errors, by
> delaying the checking until dispatch.  We can't delay the checking, so
> delay the reporting.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   monitor.c | 23 +++++++++++++++--------
>   1 file changed, 15 insertions(+), 8 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org