Re: [Qemu-devel] [PATCH 26/32] qmp: Simplify monitor_qmp_respond()

[Eric Blake]

On 07/02/2018 11:22 AM, Markus Armbruster wrote:
> monitor_qmp_respond() takes both a response object and an error
> object.  If an error object is non-null, the response object must be
> null, and the response is built from the error object.
>
> Of the two callers, one always passes a null response object, and one
> a null error object.  Move building the response object from the error
> object to the latter, and drop the error object parameter.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   monitor.c | 26 ++++++++++----------------
>   1 file changed, 10 insertions(+), 16 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org