[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_bre
Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check
Tue, 3 Jul 2018 13:31:56 +1000
On Mon, Jul 02, 2018 at 11:22:57PM -0400, Emilio G. Cota wrote:
> On Tue, Jul 03, 2018 at 11:03:48 +1000, David Gibson wrote:
> > On Mon, Jul 02, 2018 at 06:02:07PM -0400, Emilio G. Cota wrote:
> > > The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert
> > > to TranslatorOps", 2018-02-16).
> > >
> > > Fix it by setting is_jmp, so that we break from the translation loop
> > > as originally intended.
> > >
> > > Tested-by: Mark Cave-Ayland <address@hidden>
> > > Reported-by: Mark Cave-Ayland <address@hidden>
> > > Signed-off-by: Emilio G. Cota <address@hidden>
> > > ---
> > > (I'll send this to qemu-stable (for 2.12) once it's on master.)
> > Applied to ppc-for-3.0. It's kind of lucky I happened to pick this up
> > on qemu-ppc - I'm not able to read that all the time. Things will get
> > merged much faster if you CC me directly on things to go through the
> > ppc tree.
> Sorry I forgot to Cc you -- will do better next time.
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
Description: PGP signature