[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts |
Date: |
Wed, 4 Jul 2018 16:51:04 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Wed, Jul 04, 2018 at 12:39:14PM -0300, Philippe Mathieu-Daudé wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/typecast.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir . --in-place
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> crypto/cipher-builtin.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c
> index d8c811fd33..7eff760f0a 100644
> --- a/crypto/cipher-builtin.c
> +++ b/crypto/cipher-builtin.c
> @@ -133,7 +133,7 @@ static void qcrypto_cipher_aes_xts_encrypt(const void
> *ctx,
> {
> const QCryptoCipherBuiltinAESContext *aesctx = ctx;
>
> - qcrypto_cipher_aes_ecb_encrypt((AES_KEY *)&aesctx->enc,
> + qcrypto_cipher_aes_ecb_encrypt(&aesctx->enc,
> src, dst, length);
qcrypto_cipher_aes_ecb_encrypt expects a 'AES_KEY *' parameter, but
'&aesctx->enc, is a 'const AES_KEY *'. The cast is needed to discard
the const-ness.
> @@ -145,7 +145,7 @@ static void qcrypto_cipher_aes_xts_decrypt(const void
> *ctx,
> {
> const QCryptoCipherBuiltinAESContext *aesctx = ctx;
>
> - qcrypto_cipher_aes_ecb_decrypt((AES_KEY *)&aesctx->dec,
> + qcrypto_cipher_aes_ecb_decrypt(&aesctx->dec,
> src, dst, length);
Same here.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH 0/8] Coccinelle cleanups, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 1/8] qobject: Catch another straggler for use of qdict_put_str(), Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagate() calls, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- Re: [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts,
Daniel P . Berrangé <=
- [Qemu-devel] [PATCH 4/8] xen: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04