[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor
Re: [Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct
Thu, 05 Jul 2018 10:51:33 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Peter Xu <address@hidden> writes:
> It was put into the request object to show whether we'll need to resume
> the monitor after dispatching the command. Now we move that into the
> monitor struct so that it might be even used in other places in the
> future, e.g., out-of-band message flow controls.
> One thing to mention is that there is no lock needed before when
> accessing the flag since the request object will always be owned by a
> single thread. After we move it into monitor struct we need to protect
> that flag since it might be accessed by multiple threads now. Renaming
> the qmp_queue_lock into qmp_lock to protect the flag as well.
> No functional change.
> Signed-off-by: Peter Xu <address@hidden>
Marc-André's "[PATCH v3 04/38] monitor: no need to save need_resume" and
"[PATCH v3 05/38] monitor: further simplify previous patch" also mess
with need_resume. Marc-André, could you have a look at this patch and
the next one?
[Qemu-devel] [PATCH 5/9] monitor: suspend monitor instead of send CMD_DROP, Peter Xu, 2018/07/04
Re: [Qemu-devel] [PATCH 5/9] monitor: suspend monitor instead of send CMD_DROP, Markus Armbruster, 2018/07/06