[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_co_create_o

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_co_create_opts_luks to avoid a memory leak
Date: Thu, 5 Jul 2018 12:20:22 +0200
User-agent: Mutt/1.9.1 (2017-09-22)

Am 04.07.2018 um 17:02 hat Philippe Mathieu-Daudé geschrieben:
> After 1ec4f4160a1 Coverity reported:
>   Variable cryptoopts going out of scope leaks the storage it points to.
> Fixes: Coverity CID 1393782 (Resource leak)
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

I already sent a much simpler fix:
[PATCH] block/crypto: Fix memory leak in create error path

The only thing that is needed is replacing the return with a goto.
Splitting it in three different error paths is unnecessary because the
cleanup function handle NULL values just fine.

> I think this check is superfluous but I respected the previous code:
>      ret = block_crypto_co_create_generic(bs, size, create_opts, errp);
>      if (ret > 0) {
>          ret = 0;
>      }

It is wrong, too. The old code keep the error code, goto fail skipped
the ret = 0.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]