[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/38] json: remove useless return value from
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 09/38] json: remove useless return value from lexer/parser |
|
Date: |
Thu, 05 Jul 2018 13:49:55 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> The lexer always returns 0 when char feeding. Furthermore, none of the
> caller care about the return value.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
My intuitive reaction was "how come the lexer can't fail?" It can, but
it communicates failure by pushing JSON_ERROR to the streamer, not by
having the feed function return an error.
Reviewed-by: Markus Armbruster <address@hidden>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 09/38] json: remove useless return value from lexer/parser,
Markus Armbruster <=