[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] cli qmp: Mark --preconfig, exit-preconfig e
Re: [Qemu-devel] [PATCH 2/2] cli qmp: Mark --preconfig, exit-preconfig experimental
Fri, 06 Jul 2018 08:31:02 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Eric Blake <address@hidden> writes:
> On 07/05/2018 04:14 AM, Markus Armbruster wrote:
>> Committing to the current --preconfig / exit-preconfig interface
>> before it has seen any use is premature. Mark both as experimental,
>> the former in documentation, the latter by renaming it to
>> See the previous commit for more detailed rationale.
> Should the CLI be spelled --x-preconfig?
Would be the first use of x- with option names.
Since you have to pair --preconfig with x-exit-preconfig, I figure
slapping x- onto the latter suffices. But I'm not opposed to slapping
it onto the former as well.
>> Signed-off-by: Markus Armbruster <address@hidden>
> Other than the potential for a spelling change,
> Reviewed-by: Eric Blake <address@hidden>