[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF |
Date: |
Fri, 6 Jul 2018 11:43:06 +0100 |
On 5 July 2018 at 19:07, Peter Maydell <address@hidden> wrote:
> On 5 July 2018 at 19:04, Richard Henderson <address@hidden> wrote:
>> These instructions must perform the sve_access_check, but
>> since they are implemented as NOPs there is no generated
>> code to elide when the access check fails.
>>
>> Fixes: Coverity issues 1393780 & 1393779.
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>>
>> Does anyone know if this actually works for Coverity?
>> I'd hate to churn the code without knowing.
>
> Googling suggests that cast-to-void works. I tend to just mark
> them as false-positive in the Coverity GUI, though...
In this case, since you've written the patch we may as well
use it -- it works for human readers too.
Applied to target-arm.next, thanks.
-- PMM