[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: replace scrollingDeltaY with del

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: replace scrollingDeltaY with deltaY
Date: Fri, 6 Jul 2018 15:30:29 +0100

On 6 July 2018 at 15:22, G 3 <address@hidden> wrote:
> On Jul 6, 2018, at 5:11 AM, Peter Maydell wrote:
>> On 6 July 2018 at 03:53, John Arbuckle <address@hidden> wrote:
>>> The NSEvent class method scrollingDeltaY is available
>>> for Mac OS 10.7 and newer. Since QEMU supports Mac OS
>>> 10.5 and up, we need to be using a method that is
>>> available on these version of Mac OS X. The deltaY
>>> method is a method that does the same thing as
>>> scrollingDeltaY and is available on Mac OS 10.5 and
>>> up. So we simply replace scrollingDeltaY with deltaY.
>> Commit message doesn't match code change.
> Did you want me to add information on dropping events with a
> deltaY value of zero?

Yes. The code is not doing a simple replace of one method
with the other, so the commit message shouldn't say it is.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]