qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12


From: Moger, Babu
Subject: Re: [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12
Date: Mon, 9 Jul 2018 15:48:18 +0000

Looks good. thanks

> -----Original Message-----
> From: Eduardo Habkost [mailto:address@hidden
> Sent: Monday, July 2, 2018 8:10 PM
> To: address@hidden
> Cc: Eduardo Habkost <address@hidden>; Paolo Bonzini
> <address@hidden>; Moger, Babu <address@hidden>; Michael
> S. Tsirkin <address@hidden>; Igor Mammedov <address@hidden>
> Subject: [PATCH] pc: Fix typo on PC_COMPAT_2_12
> 
> I forgot a hyphen when amending the compat code on commit
> e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU").
> 
> Fixes: e00516475c270dcb6705753da96063f95699abf2
> Signed-off-by: Eduardo Habkost <address@hidden>

Reviewed-by: Babu Moger <address@hidden>

> ---
> Bug detected by compat_checker:
> https://github.com/ehabkost/gdb-qemu
> ---
>  include/hw/i386/pc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 4d99d69681..654003f44c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *,
> uint64_t *);
>          .property = "xlevel",\
>          .value    = stringify(0x8000000a),\
>      },{\
> -        .driver   = "EPYC-IBPB" TYPE_X86_CPU,\
> +        .driver   = "EPYC-IBPB-" TYPE_X86_CPU,\
>          .property = "xlevel",\
>          .value    = stringify(0x8000000a),\
>      },
> --
> 2.18.0.rc1.1.g3f1ff2140




reply via email to

[Prev in Thread] Current Thread [Next in Thread]