[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for 3.0 00/10] various docker fixes

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH for 3.0 00/10] various docker fixes
Date: Tue, 10 Jul 2018 15:06:28 +0800
User-agent: Mutt/1.10.0 (2018-05-17)

On Mon, 07/09 16:21, Alex Bennée wrote:
> Hi,
> The addition of the cross compilers for check-tcg broke the ability to
> run "make docker-test".  In truth this was probably already broken as
> it attempts to run every single test with every single docker image
> which isn't something that gets done on a regular basis.
> Anyway the patches clean up the ability to do that in a sane way
> although it still takes a long time to run the full test set.
> To help with running a better subset I've expanded the individual
> tests so you can now run a line like:
>   make docker-test-build TARGET_LIST=aarch64-softmmu J=30
> To make sure your favourite architecture still builds everywhere.
> There is now also a docker-test-unit which just runs the unit tests
> although we have to do a little re-factoring to make sure we don't
> attempt to run "make check" steps when the docker image isn't capable
> of it. This is also needed to make sure the other test-FOO build tests
> don't choke on the check step.
> Finally there is a minor tweak for .gitignore and a fix for docker.py
> throwing backtraces when we attempt to calculate SID_AGE. A cleaner
> re-factoring can be left for a future release.

Thanks for the clean ups!

Looks good in general. The only thing I notice is the test-unit script.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]