qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa


From: Dou Liyang
Subject: Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()
Date: Tue, 10 Jul 2018 18:33:33 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

Hi Eduardo,

At 07/10/2018 06:27 PM, Eduardo Habkost wrote:
On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote:
[...]
+    if (nb_numa_nodes)
           machine_numa_finish_cpu_init(machine);
-    }
missing curly brackets, should look like:
         if (nb_numa_nodes) {
             machine_numa_finish_cpu_init(machine);
         }

with that fixed
Reviewed-by: Igor Mammedov <address@hidden>


Thank you, Igor.

Due to Eduardo has sent the pull request of this patch,
Can I fix this and send v2 patch now?

You can fix this on a follow-up patch and CC qemu-trivial.


Ok, I see. ;-)

Thanks,
        dou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]