[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial |
Date: |
Tue, 10 Jul 2018 17:59:51 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote:
> On 10 July 2018 at 15:22, Cornelia Huck <address@hidden> wrote:
> > On Tue, 10 Jul 2018 07:59:15 +0200
> > Markus Armbruster <address@hidden> wrote:
> >
> >> In addition to actively pulling libvirt developers into review of
> >> deprecation patches, we should pursue the idea to optionally let QEMU
> >> fail on use of deprecated features, then have libvirt run its test suite
> >> that way.
> >
> > What about the following:
> >
> > qemu_deprecated_option("old_option", "modern_option");
> >
> > Which would then print (in normal operation)
> >
> > "WARNING: 'old_option' is deprecated and will be removed; use
> > 'modern_option' instead"
> >
> > to the monitor (or to stderr? to both?).
> >
> > If you start QEMU with a -no-deprecated-options switch, it would print
> >
> > "ERROR: 'old_option' is deprecated and will be removed; use 'modern_option'
> > instead"
>
> I'd prefer to see more hand-tailored deprecation messages that can
> be more detailed about exactly what the new syntax needs to be.
> The ideal would be if you could get right down to the detailed
> level of "replace -old_thing -with_foo=x with -device new_thing,foo=x"...
Agreed, the more detail we can provide the better for users.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, (continued)
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/07/09
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/09
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Cornelia Huck, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Cornelia Huck, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Maydell, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial,
Daniel P . Berrangé <=
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Thomas Huth, 2018/07/09
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Cornelia Huck, 2018/07/09