[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] virtio-scsi: fix hotplug ->reset() vs event
Re: [Qemu-devel] [PATCH 0/2] virtio-scsi: fix hotplug ->reset() vs event race
Wed, 11 Jul 2018 11:13:54 +0800
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
Ok, I will test your patch soon.
On 2018/7/10 23:50, Stefan Hajnoczi wrote:
The virtio-scsi command virtqueues run during hotplug. This creates the
possibility of race conditions since the guest can submit commands while the
monitor is performing hotplug.
See Patch 2 for a fix for the ->reset() vs event race condition that Zhengui Li
Zhengui Li: Sorry it took me so long to look into this. Please let me know if
this fixes the issue you are seeing. Thanks!
Stefan Hajnoczi (2):
qdev: add HotplugHandler->post_plug() callback
virtio-scsi: fix hotplug ->reset() vs event race
include/hw/hotplug.h | 12 ++++++++++++
hw/core/hotplug.c | 11 +++++++++++
hw/core/qdev.c | 7 +++++++
hw/scsi/virtio-scsi.c | 11 ++++++++++-
4 files changed, 40 insertions(+), 1 deletion(-)