[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node
Date: Thu, 12 Jul 2018 14:07:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 11/07/2018 19:52, Emanuele wrote:
>> Do you intend to delete this comment before this series is merged?  It
>> seems like a TODO that doesn't need to be kept around.
> Paolo suggested me to put it there, because there still are some devices
> that need to be implemented.
>>> +    qos_add_test("sdhci-test", "sdhci", test_machine);
>> How does this work for tests that need access to more than 1 device?
>> Can they request a driver instance via the API?
> Uhm accessing more than one device is something I did not take into
> account. It is possible to add additional command line to the test, with
> qos_add_test_args(), but no multiple devices. I'll add it as TODO in my
> list, thanks

Note that there is only one test that requires multiple devices on the
same bus, namely usb-hcd-ehci-test.c which instantiates the EHCI
controller under test together with three companion UHCI controllers.

One possibility is to define a driver which contains all of the devices
you need in the test, and make the test depend on the driver.  Maybe
there is a better way to do it, the above is just what came to my mind.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]