[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V1 RESEND 0/6] Build ACPI Heterogeneous Memory A
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH V1 RESEND 0/6] Build ACPI Heterogeneous Memory Attribute Table (HMAT) |
Date: |
Mon, 16 Jul 2018 14:00:35 +0200 |
On Tue, 19 Jun 2018 23:20:51 +0800
Liu Jingqi <address@hidden> wrote:
> This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
> according to the command line. The ACPI HMAT describes the memory attributes,
> such as memory side cache attributes and bandwidth and latency details,
> related to the System Physical Address (SPA) Memory Ranges.
> The software is expected to use this information as hint for optimization.
>
> OSPM evaluates HMAT only during system initialization. Any changes to the HMAT
> state at runtime or information regarding HMAT for hot plug are communicated
> using the _HMA method.
>
> Liu Jingqi (6):
> hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI
> HMAT
you've converted this patch to build_append_int_noprefix() API as requested
> hmat acpi: Build System Locality Latency and Bandwidth Information
> Structure(s) in ACPI HMAT
> hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI
> HMAT
but left out above 2 with the same issues.
So I'd repeat,
using "struct FOO {} packed" is discouraged, you should use
build_append_int_noprefix() API to build ACPI tables
> numa: Extend the command-line to provide memory latency and bandwidth
> information
> numa: Extend the command-line to provide memory side cache information
> hmat acpi: Implement _HMA method to update HMAT at runtime
>
> default-configs/x86_64-softmmu.mak | 1 +
> hw/acpi/Makefile.objs | 1 +
> hw/acpi/hmat.c | 649
> +++++++++++++++++++++++++++++++++++++
> hw/acpi/hmat.h | 264 +++++++++++++++
> hw/i386/acpi-build.c | 122 ++++---
> hw/i386/acpi-build.h | 10 +
> hw/i386/pc.c | 2 +
> hw/i386/pc_piix.c | 3 +
> hw/i386/pc_q35.c | 3 +
> include/hw/i386/pc.h | 2 +
> include/sysemu/numa.h | 2 +
> numa.c | 202 ++++++++++++
> qapi/misc.json | 160 ++++++++-
> qemu-options.hx | 28 +-
> 14 files changed, 1401 insertions(+), 48 deletions(-)
> create mode 100644 hw/acpi/hmat.c
> create mode 100644 hw/acpi/hmat.h
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH V1 RESEND 0/6] Build ACPI Heterogeneous Memory Attribute Table (HMAT),
Igor Mammedov <=