Re: [Qemu-devel] [PATCH 07/25] check: Only test pcnet when it is compiled in

[Thomas Huth]

On 17.07.2018 13:33, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  tests/Makefile.include | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 560f486416..a039b70f9b 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -215,9 +215,9 @@ check-qtest-pci-y += tests/e1000e-test$(EXESUF)
>  gcov-files-pci-y += hw/net/e1000e.c hw/net/e1000e_core.c
>  check-qtest-pci-y += tests/rtl8139-test$(EXESUF)
>  gcov-files-pci-y += hw/net/rtl8139.c
> -check-qtest-pci-y += tests/pcnet-test$(EXESUF)
> -gcov-files-pci-y += hw/net/pcnet.c
> -gcov-files-pci-y += hw/net/pcnet-pci.c
> +check-qtest-pci-$(CONFIG_PCNET_PCI) += tests/pcnet-test$(EXESUF)
> +gcov-files-pci-$(CONFIG_PCNET_PCI) += hw/net/pcnet.c
> +gcov-files-pci-$(CONFIG_PCNET_PCI) += hw/net/pcnet-pci.c
>  check-qtest-pci-$(CONFIG_EEPRO100_PCI) += tests/eepro100-test$(EXESUF)
>  gcov-files-pci-$(CONFIG_EEPRO100_PCI) += hw/net/eepro100.c
>  check-qtest-pci-$(CONFIG_NE2000_PCI) += tests/ne2000-test$(EXESUF)

Reviewed-by: Thomas Huth <address@hidden>