[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems |
Date: |
Wed, 18 Jul 2018 09:22:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 17.07.2018 22:27, Alistair Francis wrote:
> This is based on Thomas's work fixing introspection problems [1] and
> applied to the RISC-V port.
>
> 1: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03261.html
>
> Alistair Francis (5):
> sifive_e: Fix crash when introspecting the device
> sifive_u: Fix crash when introspecting the device
> virt: Fix crash when introspecting the device
> riscv_hart: Fix crash when introspecting the device
> spike: Fix crash when introspecting the device
>
> hw/riscv/riscv_hart.c | 7 +++----
> hw/riscv/sifive_e.c | 12 ++++++------
> hw/riscv/sifive_u.c | 15 +++++++--------
> hw/riscv/spike.c | 10 ++++------
> hw/riscv/virt.c | 5 ++---
> 5 files changed, 22 insertions(+), 27 deletions(-)
That's interesting, these issues did not appear in my tests (modified
tests/device-introspect-test.c with hmp("info qtree")). Likely because
device-introspect-test only checks with the "none" machine ==> one more
reason to test here with all machines, too (I suggested such a patch a
couple of months ago) ...
Thomas