[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface n

From: Emanuele
Subject: Re: [Qemu-devel] [PATCH 2/7] tests/qgraph: pci-pc driver and interface nodes
Date: Wed, 18 Jul 2018 22:49:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 07/18/2018 09:33 PM, Paolo Bonzini wrote:
On 18/07/2018 20:29, Emanuele wrote:
I had to put this patch here because it also introduces
qpci_device_init, used by sdhci (patch 3).

For the next version I plan to have a patch X where I rename all
occurrences of qpci_init_pc in qpci_pc_new, and a patch X+1 that
introduces qpci_init_pc (was qpci_set_pc) and the other changes.

Should I only introduce qpci_device_init in patch 3 and the remaining
things in patch 5?

I think the general problem here is that in some patches I create
functions that are planned to only be used only in next patches (of the
current series).
I think it's okay this way, however you should justify the changes you
make to "qgraph-ify" each component.

For patch 1, let's wait for Stefan's reply.  Because patch 1 is
introducing the infrastructure, I think it is acceptable that some
definitions are introduced early as long as they have doc comments; it
would make little sense to introduce get_device in patch 4 just because
there are no "contains" edges until then.

However, introducing the qos-test directly at the beginning is also a

In either case, we need better doc comments for the function pointers in
What would you suggest as better doc comments? For version 2 I have written a little introduction like in qom/object.h, essentially pasting the cover letter and a working example.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]