[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] monitor: print message when using 'help' with an un

From: Collin Walling
Subject: [Qemu-devel] [PATCH] monitor: print message when using 'help' with an unknown command
Date: Thu, 19 Jul 2018 11:03:37 -0400

When typing 'help' followed by an unknown command, QEMU will
not print anything to the command line to let the user know
they typed a bad command. Let's fix this by printing a message
to the monitor when this happens. For example:

    (qemu) help xyz
    unknown command: 'xyz'

Reported-by: Stefan Zimmermann <address@hidden>
Signed-off-by: Collin Walling <address@hidden>
 monitor.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/monitor.c b/monitor.c
index 7af1f18..7942f9f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1034,9 +1034,12 @@ static void help_cmd_dump(Monitor *mon, const mon_cmd_t 
             } else {
                 help_cmd_dump_one(mon, cmd, args, arg_index);
-            break;
+            return;
+    /* Entry not found */
+    monitor_printf(mon, "unknown command: '%s'\n", args[arg_index]);
 static void help_cmd(Monitor *mon, const char *name)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]