[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 15/17] kvm: add vCPU failed memeory access pr
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v1 15/17] kvm: add vCPU failed memeory access processing |
Date: |
Fri, 20 Jul 2018 17:44:23 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Wed, Jul 18, 2018 at 06:41:58PM +0300, Denis Plotnikov wrote:
> Is done with support of the KVM patch returning the faulting address.
>
> Signed-off-by: Denis Plotnikov <address@hidden>
I feel like these two kvm-related patches can be put at the end of the
series as an extension to kvm support. E.g., without these kvm
patches one should still be able to do live snapshot with TCG. Then
even if your KVM patches are not settled (along with the header
update) there's still chance that your framework can be merged first.
> ---
> target/i386/kvm.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 3ac5302bc5..55b8860d1a 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -45,6 +45,8 @@
> #include "hw/pci/msi.h"
> #include "hw/pci/msix.h"
> #include "migration/blocker.h"
> +#include "migration/savevm.h"
> +#include "migration/ram.h"
> #include "exec/memattrs.h"
> #include "trace.h"
>
> @@ -3130,6 +3132,18 @@ static bool host_supports_vmx(void)
> return ecx & CPUID_EXT_VMX;
> }
>
> +static int kvm_handle_fail_mem_access(CPUState *cpu)
> +{
> + struct kvm_run *run = cpu->kvm_run;
> + int ret = ram_process_page_fault((void *)run->fail_mem_access.hva);
> +
> + if (ret >= 0) {
> + cpu_resume(cpu);
> + }
> +
> + return ret;
> +}
> +
> #define VMX_INVALID_GUEST_STATE 0x80000021
>
> int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run)
> @@ -3188,6 +3202,9 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run
> *run)
> ioapic_eoi_broadcast(run->eoi.vector);
> ret = 0;
> break;
> + case KVM_EXIT_FAIL_MEM_ACCESS:
> + ret = kvm_handle_fail_mem_access(cs);
> + break;
> default:
> fprintf(stderr, "KVM: unknown exit reason %d\n", run->exit_reason);
> ret = -1;
> --
> 2.17.0
>
>
Regards,
--
Peter Xu
- [Qemu-devel] [PATCH v1 13/17] background snapshot: add write-protected page access handler function, (continued)
- [Qemu-devel] [PATCH v1 13/17] background snapshot: add write-protected page access handler function, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 06/17] background snapshot: add helpers to manage a copy of ram block list, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 08/17] migration: add helpers to change VM memory protection rights, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 02/17] bitops: add some atomic versions of bitmap operations, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 10/17] background snapshots: adapt the page queueing code for using page copies, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 09/17] background snapshot: extend RAM request for holding a page copy pointer, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 15/17] kvm: add vCPU failed memeory access processing, Denis Plotnikov, 2018/07/18
- Re: [Qemu-devel] [PATCH v1 15/17] kvm: add vCPU failed memeory access processing,
Peter Xu <=
- [Qemu-devel] [PATCH v1 14/17] kvm: add failed memeory access exit reason, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 12/17] ram: add background snapshot support in ram page saving part of migration, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 04/17] background snapshot: make a dedicated type for ram block list, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 07/17] background snapshot: introduce page buffer, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 11/17] background snapshot: add a memory page copying function, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 03/17] threads: add infrastructure to process sigsegv, Denis Plotnikov, 2018/07/18
- [Qemu-devel] [PATCH v1 16/17] migration: move the device state saving logic to a separate function, Denis Plotnikov, 2018/07/18