[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/spitz: Move problematic nand_init() code
Re: [Qemu-devel] [PATCH] hw/arm/spitz: Move problematic nand_init() code to realize function
Fri, 20 Jul 2018 16:03:44 +0100
On 19 July 2018 at 14:15, Thomas Huth <address@hidden> wrote:
> nand_init() does not only create the NAND device, it also realizes
> the device with qdev_init_nofail() already. So we must not call
> nand_init() from an instance_init function like sl_nand_init(),
> otherwise we get superfluous NAND devices in the QOM tree after
> introspecting the 'sl-nand' device. So move the nand_init() to the
> realize function of 'sl-nand' instead.
> Signed-off-by: Thomas Huth <address@hidden>
> hw/arm/spitz.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
Applied to target-arm.next, thanks.