[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file i
Daniel P . Berrangé
Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149
Mon, 23 Jul 2018 14:55:19 +0100
On Mon, Jul 23, 2018 at 03:53:45PM +0200, Kevin Wolf wrote:
> Am 13.07.2018 um 20:12 hat John Snow geschrieben:
> > On 07/13/2018 03:10 AM, Kevin Wolf wrote:
> > > The test case uses block devices with driver=file, which causes the test
> > > to fail after commit 230ff73904 added a deprecation warning for this.
> > > Fix the test case to use driver=host_device and update the reference
> > > output accordingly.
> > >
> > > Signed-off-by: Kevin Wolf <address@hidden>
> > 149 [not run] requires password-less sudo access: sudo: a
> > password is required
> > Ah, this one hides from regression scripts quite well...
> > This test fails both before and after this patch for me, with
> > +Traceback (most recent call last):
> > + File "149", line 525, in <module>
> > + test_once(config, qemu_img=False)
> > + File "149", line 336, in test_once
> > + cryptsetup_open(config)
> > + File "149", line 200, in cryptsetup_open
> > + cryptsetup(args, password)
> > + File "149", line 124, in cryptsetup
> > + raise Exception(msg)
> > +Exception: Device qiotest-145-twofish-128-xts-plain64-sha1 already exists.
> > +Command failed with code 17: File exists
> > Am I missing some prerequisite, maybe?
> Hm, sounds a bit like a failed first attempt that didn't clean up behind
> itself properly? Just guessing though.
Yeah, sounds like it failed badly enough that cleanup broke.
Can probably fix it by either rebooting, or the more nuanced:
cryptsetup luksClose qiotest-145-twofish-128-xts-plain64-sha1
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|