[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/8] migration: do not wait for free thread

From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v2 1/8] migration: do not wait for free thread
Date: Tue, 24 Jul 2018 15:40:18 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/24/2018 02:36 AM, Eric Blake wrote:
On 07/19/2018 07:15 AM, address@hidden wrote:
From: Xiao Guangrong <address@hidden>

Instead of putting the main thread to sleep state to wait for
free compression thread, we can directly post it out as normal
page that reduces the latency and uses CPUs more efficiently

A parameter, compress-wait-thread, is introduced, it can be
enabled if the user really wants the old behavior

Signed-off-by: Xiao Guangrong <address@hidden>
  hmp.c                 |  8 ++++++++
  migration/migration.c | 21 +++++++++++++++++++++
  migration/migration.h |  1 +
  migration/ram.c       | 45 ++++++++++++++++++++++++++-------------------
  qapi/migration.json   | 23 ++++++++++++++++++-----
  5 files changed, 74 insertions(+), 24 deletions(-)

+++ b/qapi/migration.json
@@ -462,6 +462,11 @@
  # @compress-threads: Set compression thread count to be used in live 
  #          the compression thread count is an integer between 1 and 255.
+# @compress-wait-thread: Wait if no thread is free to compress the memory page
+#          if it's enabled, otherwise, the page will be posted out immediately
+#          in the main thread without compression. It's off on default.
+#          (Since: 3.0)

Is this a bug fix? It's awfully late in the release cycle to be adding new 
features; is this something that we can live without until 3.1?

It's performance improvement, i think it is not urgent. :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]