[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: prevent stuck command key when g

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: prevent stuck command key when going into full screen mode
Date: Tue, 24 Jul 2018 12:39:12 +0100

On 3 July 2018 at 03:00, John Arbuckle <address@hidden> wrote:
> When the user pushes Command-F in QEMU while the mouse is ungrabbed, QEMU
> goes into full screen mode. When the user finally releases the command key,
> it is sent to the guest as an event. The makes the guest operating system
> think the command key is down when it is really up. To prevent this situation
> from happening, we simply drop the first command key event after the user has
> gone into full screen mode using Command-F.
> Signed-off-by: John Arbuckle <address@hidden>
> ---

I feel like there might be a more elegant way to handle this
(surely the NSEventTypeFlagsChanged event can have some way
to query the current state of the modifier flags even if it's
got a keycode value? the current code which has different
approaches for "have a keycode" vs not seems a bit fragile),
but this fix should work. Applied to master for 3.0, thanks.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]