[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] migration: fix duplicate initialization for
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] migration: fix duplicate initialization for expected_downtime and cleanup_bh |
Date: |
Tue, 24 Jul 2018 15:33:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Lidong Chen <address@hidden> wrote:
> migrate_fd_connect duplicate initialize expected_downtime and cleanup_bh.
>
> Signed-off-by: Lidong Chen <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Good catch.
Inserted here.
commit d3e35b8f6248eab2c3d412198a487ae49706b214
Author: Peter Xu <address@hidden>
Date: Wed May 2 18:47:24 2018 +0800
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index ff05422..b8c4fec 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3032,8 +3032,6 @@ void migrate_fd_connect(MigrationState *s, Error
> *error_in)
> } else {
> /* This is a fresh new migration */
> rate_limit = s->parameters.max_bandwidth / XFER_LIMIT_RATIO;
> - s->expected_downtime = s->parameters.downtime_limit;
> - s->cleanup_bh = qemu_bh_new(migrate_fd_cleanup, s);
>
> /* Notify before starting migration thread */
> notifier_list_notify(&migration_state_notifiers, s);