[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 10/20] qmp event: Add COLO_EXIT event to not
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH V10 10/20] qmp event: Add COLO_EXIT event to notify users while exited COLO |
Date: |
Tue, 24 Jul 2018 15:54:30 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
* Zhang Chen (address@hidden) wrote:
> On Tue, Jul 24, 2018 at 2:41 AM, Eric Blake <address@hidden> wrote:
>
> > On 07/22/2018 02:33 PM, Zhang Chen wrote:
> >
> >> From: zhanghailiang <address@hidden>
> >>
> >> If some errors happen during VM's COLO FT stage, it's important to
> >> notify the users of this event. Together with 'x-colo-lost-heartbeat',
> >> Users can intervene in COLO's failover work immediately.
> >> If users don't want to get involved in COLO's failover verdict,
> >> it is still necessary to notify users that we exited COLO mode.
> >>
> >> Signed-off-by: zhanghailiang <address@hidden>
> >> Signed-off-by: Li Zhijian <address@hidden>
> >> Signed-off-by: Zhang Chen <address@hidden>
> >> Reviewed-by: Eric Blake <address@hidden>
> >> Reviewed-by: Markus Armbruster <address@hidden>
> >> ---
> >> migration/colo.c | 31 +++++++++++++++++++++++++++++++
> >> qapi/migration.json | 38 ++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 69 insertions(+)
> >>
> >
> > At this point in the release cycle, this series feels like enough of a new
> > feature (rather than a bug fix) that it is probably not appropriate for
> > 3.0, which means...
> >
> >
> > +++ b/qapi/migration.json
> >> @@ -900,6 +900,44 @@
> >> { 'enum': 'FailoverStatus',
> >> 'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
> >> +##
> >> +# @COLO_EXIT:
> >> +#
> >> +# Emitted when VM finishes COLO mode due to some errors happening or
> >> +# at the request of users.
> >> +#
> >> +# @mode: report COLO mode when COLO exited.
> >> +#
> >> +# @reason: describes the reason for the COLO exit.
> >> +#
> >> +# Since: 3.0
> >>
> >
> > ...this and other references should be updated to 3.1.
>
>
> OK, I will fix it and resend this series.
No need to resend now; resend after the review of the other bits in the
series; I'm sure there will be other minor things; anyway we can always
fix up version nunmbers in merge.
Dave
> Thanks
> Zhang Chen
>
>
> >
> >
> > --
> > Eric Blake, Principal Software Engineer
> > Red Hat, Inc. +1-919-301-3266
> > Virtualization: qemu.org | libvirt.org
> >
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH V10 03/20] colo-compare: use notifier to notify packets comparing result, (continued)
- [Qemu-devel] [PATCH V10 03/20] colo-compare: use notifier to notify packets comparing result, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 04/20] COLO: integrate colo compare with colo frame, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 05/20] COLO: Add block replication into colo process, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 06/20] COLO: Remove colo_state migration struct, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 07/20] COLO: Load dirty pages into SVM's RAM cache firstly, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 08/20] ram/COLO: Record the dirty pages that SVM received, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 09/20] COLO: Flush memory data from ram cache, Zhang Chen, 2018/07/22
- [Qemu-devel] [PATCH V10 10/20] qmp event: Add COLO_EXIT event to notify users while exited COLO, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 11/20] qapi/migration.json: Rename COLO unknown mode to none mode., Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 12/20] qapi: Add new command to query colo status, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 13/20] savevm: split the process of different stages for loadvm/savevm, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 14/20] COLO: flush host dirty ram from cache, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 15/20] net/net.c: Add net client type check function for COLO, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 16/20] filter: Add handle_event method for NetFilterClass, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 17/20] filter-rewriter: handle checkpoint and failover event, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 18/20] COLO: notify net filters about checkpoint/failover event, Zhang Chen, 2018/07/22
[Qemu-devel] [PATCH V10 19/20] COLO: quick failover process by kick COLO thread, Zhang Chen, 2018/07/22