[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/7] migration: update recv bitmap only on dest vm
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 4/7] migration: update recv bitmap only on dest vm |
Date: |
Tue, 24 Jul 2018 19:34:51 +0100 |
From: Peter Xu <address@hidden>
We shouldn't update the received bitmap if we're the source VM. This
fixes a breakage when release-ram is enabled on postcopy.
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/ram.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index fdd108475c..24dea2730c 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2827,8 +2827,15 @@ int ram_discard_range(const char *rbname, uint64_t
start, size_t length)
goto err;
}
- bitmap_clear(rb->receivedmap, start >> qemu_target_page_bits(),
- length >> qemu_target_page_bits());
+ /*
+ * On source VM, we don't need to update the received bitmap since
+ * we don't even have one.
+ */
+ if (rb->receivedmap) {
+ bitmap_clear(rb->receivedmap, start >> qemu_target_page_bits(),
+ length >> qemu_target_page_bits());
+ }
+
ret = ram_block_discard_range(rb, start, length);
err:
--
2.17.1
- [Qemu-devel] [PULL 0/7] migration queue for 3.0, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 1/7] migration: fix potential overflow in multifd send, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 2/7] migrate: Fix cancelling state warning, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 4/7] migration: update recv bitmap only on dest vm,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 3/7] audio/hda: Fix migration, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 5/7] migration: disallow recovery for release-ram, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 6/7] tests: only update last_byte when at the edge, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 7/7] migration: fix duplicate initialization for expected_downtime and cleanup_bh, Dr. David Alan Gilbert (git), 2018/07/24
- Re: [Qemu-devel] [PULL 0/7] migration queue for 3.0, Peter Maydell, 2018/07/24