|
| From: | Eric Blake |
| Subject: | Re: [Qemu-devel] [PATCH v2 02/23] libqtest: Rename functions to send QMP messages |
| Date: | Fri, 27 Jul 2018 12:06:22 -0500 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/27/2018 11:35 AM, Thomas Huth wrote:
On 07/27/2018 05:13 PM, Markus Armbruster wrote:[...] Rename qmp_fd_sendv() to qmp_fd_vsend().Why? I think it's also quite common to have the "v" at the end, e.g. object_new_with_propv, gdb_do_syscallv, qobject_from_jsonv, etc.
Actually, I think 'printf' vs. 'vprintf' is the model to be following, and patch 23/23 brings in even more consistency. I'm in favor of this rename.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |