[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qt

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qtest_initf()
Date: Fri, 27 Jul 2018 13:52:13 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/27/2018 12:18 PM, Thomas Huth wrote:
On 07/27/2018 05:13 PM, Markus Armbruster wrote:
qtest_init() creates a new QTestState, and leaves @global_qtest alone.
qtest_start() additionally assigns it to @global_qtest, but
qtest_startf() additionall sets assigns NULL to @global_qtest.  This
makes no sense.  Replace it by qtest_initf() that works like
qtest_init(), i.e. leaves @global_qtest alone.

FWIW, the original idea was to get rid of global_qtest, and then to
remove qtest_init instead:


Not sure whether Eric is still working on these patches, though.

As pointed out in the cover letter, there are still some good things to salvage from my series, but at this point, it's been closer to a year since I last posted anything, so it is just as easy for me to rebase/rework from scratch for salvaging the good things, after this series lands.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]