[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3 03/23] libqtest: Clean up how we read device_del

From: Markus Armbruster
Subject: [Qemu-devel] [PATCH v3 03/23] libqtest: Clean up how we read device_del messages
Date: Mon, 30 Jul 2018 10:32:57 +0200

qtest_qmp_device_del() still uses the qmp("") hack to receive a
message, even though we have qmp_receive() since commit 66e0c7b187e.
Put it to use.

Bonus: gets rid of empty format strings.  A step towards compile-time
format string checking without triggering -Wformat-zero-length.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
 tests/libqtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/libqtest.c b/tests/libqtest.c
index 9cb4096639..071d7eb7b1 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1090,7 +1090,7 @@ void qtest_qmp_device_del(const char *id)
     g_assert(!qdict_haskey(response1, "error"));
-    response2 = qmp("");
+    response2 = qmp_receive();
     g_assert(!qdict_haskey(response2, "error"));

reply via email to

[Prev in Thread] Current Thread [Next in Thread]