[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate
Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature
Mon, 30 Jul 2018 10:07:27 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
On 07/28/2018 02:50 AM, Niels de Vos wrote:
Part of me wishes that libgfapi had just created a new function
'glfs_ftruncate2', so that existing users don't need to handle the api
change. But I guess in the grand scheme, not a huge deal either way.
Gluster uses versioned symbols, so older binaries will keep working with
new libraries. It is (hopefully) rare that existing symbols get updated.
We try to send patches for these kind of changes to the projects we know
well in advance, reducing the number of surprises.
I can go ahead and add that to the comment in my branch after applying, if
Niels can let me know what that version is/will be (if known).
The new glfs_ftruncate() will be part of glusterfs-5 (planned for
October). We're changing the numbering scheme, it was expected to come
in glusterfs-4.2, but that is a version that never will be released.
Wait - so you're saying gluster has not yet released the incompatible
change? Now would be the right time to get rid of the API breakage,
before you bake it in, rather than relying solely on the versioned
symbols to avoid an ABI breakage but forcing all clients to compensate
to the API breakage.
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org