[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/23] tests: Clean up string interpolation a

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 13/23] tests: Clean up string interpolation around qtest_qmp_device_add()
Date: Mon, 30 Jul 2018 10:25:26 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/30/2018 03:34 AM, Markus Armbruster wrote:
Eric Blake <address@hidden> writes:

(We really want to assert that any % interpolations in our JSON parser
are NOT embedded in '').

I'll look into that, but it'll be in a separate series.

Agreed. In fact, my more ambitious series had reached that point by implementing %% interpolation inside strings, combined with asserting that %% cannot occur except within strings during the JSON parse, then during the JSON interpolation that the only use of % within strings was the %% escape (so that we no longer risk consuming a va-arg during string interpolation, while still benefiting from gcc's -Wformat checking). So probably one of the easier things to revive, once this series lands.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]