[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_
Dr. David Alan Gilbert
Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle
Tue, 31 Jul 2018 16:38:05 +0100
* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert" <address@hidden> wrote:
> > * Li Qiang (address@hidden) wrote:
> >> The default max cpu throttle is 99, this is too big that may
> >> influence the guest loads. Add a qmp to config it can make it
> >> more flexible.
> >> Signed-off-by: Li Qiang <address@hidden>
> > This should be done as a migration parameter rather than a new command.
> > For example, follow the cpu-throttle-increment parameter; and this
> > should work just like it.
> I was about to comment this one.
> migrate_set_downtime, migrate_set_speed, migrate-set-cache-size,
> query-migrate-cache-size are marked as deprecated. Any way that we
> could have make more clear that one should use
A big hairy comment?
> Thanks, Juan.
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Qemu-devel] [PATCH 3/3] hmp: add hmp for migrate_set_max_cpu_throttle, Li Qiang, 2018/07/31