[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 45/76] target/mips: Implement emulation of na
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 45/76] target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair |
|
Date: |
Fri, 3 Aug 2018 13:28:59 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/03/2018 03:48 AM, Aleksandar Rikalo wrote:
>> > However, it looks there is a bigger problem now in SCWP. QEMU crashes with
>> > this message:
>> >
>> > /qemu/tcg/tcg.c:2862: tcg fatal error
I said remove all of the tcg_temp_local_new that were not necessary.
You removed one that was necessary. This value is live across a branch.
r~
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 8306986c86..b1525adff3 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -2473,7 +2473,7 @@ static void gen_st_cond
static void gen_scwp(DisasContext *ctx, uint32_t base, int16_t offset,
uint32_t reg1, uint32_t reg2)
{
- TCGv taddr = tcg_temp_new();
+ TCGv taddr = tcg_temp_local_new();
TCGv lladdr = tcg_temp_new();
TCGv_i64 tval = tcg_temp_new_i64();
TCGv_i64 llval = tcg_temp_new_i64();