[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] sysbus: always allow explicit_ofw_unit_addr
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] sysbus: always allow explicit_ofw_unit_address() to override address generation |
|
Date: |
Mon, 6 Aug 2018 17:06:35 -0300 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Sun, Aug 05, 2018 at 12:28:49PM +0100, Mark Cave-Ayland wrote:
> Some SysBusDevices either use sysbus_init_mmio() without
> sysbus_mmio_map() or the first MMIO memory region doesn't represent the
> bus address, causing a firmware device path with an invalid address to
> be generated.
>
> SysBusDeviceClass does provide a virtual explicit_ofw_unit_address()
> method that can be used to override this process, but it was originally
> intended
> only as as a fallback option meaning that any existing MMIO memory regions
> still
> take priority whilst determining the firmware device address.
>
> There is currently only one user of explicit_ofw_unit_address() and that
> is the PCI expander bridge (PXB) device which has no MMIO/PIO resources
> defined. This enables us to allow explicit_ofw_unit_address() to take
> priority without affecting backwards compatibility, allowing the address
> to be customised as required.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Queueing for 3.1.
--
Eduardo
- [Qemu-devel] [PATCH 2/2] fw_cfg: set the get_boot_devices_list() ignore_suffixes parameter from machine property, (continued)
[Qemu-devel] [PATCH 1/2] sysbus: always allow explicit_ofw_unit_address() to override address generation, Mark Cave-Ayland, 2018/08/05