[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GP
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GPIO |
Date: |
Thu, 9 Aug 2018 17:14:49 +0100 |
On Mon, Aug 6, 2018 at 11:01 AM, Steffen Görtz
<address@hidden> wrote:
> + /* Check Input propagates */
> + g_assert_false(true);
Each patch must compile and run successfully. This test case will
fail here. Please don't do this - even if a later patch will fill in
the missing part.
The reason for this requirement is that git-bisect(1) must work on any
commit. If the some commits don't compile or pass tests then it makes
git-bisect(1) much harder or impossible to use.
Stefan
- [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 1/7] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 7/7] hw/display/led_matrix: Add LED matrix display device, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GPIO, Steffen Görtz, 2018/08/06
- Re: [Qemu-devel] [PATCH 5/7] tests/microbit-test: Add Tests for nRF51 GPIO,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/7] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 4/7] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral, Steffen Görtz, 2018/08/06
- [Qemu-devel] [PATCH 3/7] tests: Add bbc:microbit / nRF51 test suite, Steffen Görtz, 2018/08/06