Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak

[Juan Quintela]

Paolo Bonzini <address@hidden> wrote:
> On 08/08/2018 13:48, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  default-configs/alpha-softmmu.mak       | 2 --
>>  default-configs/arm-softmmu.mak         | 2 --
>>  default-configs/hppa-softmmu.mak        | 3 ---
>>  default-configs/i386-softmmu.mak        | 2 --
>>  default-configs/mips-softmmu-common.mak | 2 --
>>  default-configs/ppc-softmmu.mak         | 1 -
>>  default-configs/ppcemb-softmmu.mak      | 2 --
>>  default-configs/sh4-softmmu.mak         | 2 --
>>  default-configs/sh4eb-softmmu.mak       | 2 --
>>  default-configs/sparc64-softmmu.mak     | 2 --
>>  default-configs/x86_64-softmmu.mak      | 2 --
>>  11 files changed, 22 deletions(-)
>
> I don't think CONFIG_SERIAL_ISA should be in pci.mak though, and
> CONFIG_SERIAL is a dependency of both CONFIG_SERIAL and
> CONFIG_SERIAL_PCI.  Perhaps introduce a superio.mak with all the legacy
> ISA devices?

Hi

Several things here.

a- I am just removing bits that are duplicated in this patch
   So I think it should got in as it is.

b- SuperIO: I would really be able to remove isapc machine type and
   isa-bus and related friends. (Yes, as put before, I know that all
   pc's have an isa bus, but no need for things like mmouse nowadays)

c- untangling piix and q35 is a bit of work.  The things that I remember
   from memory:
   * tests: we have tests for both on the same file (we can split the
     file)
   * is_default.  This is a mess.  I tried to disable "piix" machine
     types leaving only q35, and then tests complain that there is no
     default machine type.  I think that we should remove all the
     is_default logic and just choose the 1st for the list of machines
     (but that is one idea that I haven't triued to follow yet).

And that is before we start doing things like network isa cards, isa
sound cards, vmport (I hate that), parallel port, whatdog, etc, etc.

Later, Juan.