[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match a

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything
Date: Fri, 10 Aug 2018 09:39:16 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 08/10/2018 06:55 AM, Markus Armbruster wrote:
Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
hw/sparc/sun4m_iommu.c without updating MAINTAINERS.

Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating

Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.

Commit 33e9e9bd62d fat-fingered include/qemu/job.h.

Commit eb815e248f5 moved qapi-schema.json to qapi/ without updating

Commit 2e3c8f8dbdd converted docs/devel/migration.txt to
docs/devel/migration.rst without updating MAINTAINERS.

Offenders tracked down with the following shell loop:

     shopt -s nullglob
     for i in `sed -n 's/^F: //p' <MAINTAINERS `
         glob="`echo $i`"
        if [ "$glob" = "$i" ]
        then [ ! -e $i ]
        else [ -z "$glob" ]
        fi && echo "$i"

Clever. The bulk of the time spent on this patch was chasing down the faulty commits for the nice archaeology given above.

Signed-off-by: Markus Armbruster <address@hidden>
  MAINTAINERS | 10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]